Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DoH3 #214

Closed
wants to merge 1 commit into from
Closed

add DoH3 #214

wants to merge 1 commit into from

Conversation

hellodword
Copy link

As @ainar-g said,

AFAIK, the Go standard library currently doesn't support HTTP/3, and probably won't until it graduates the draft standard phase. Once it does, the Go standard library will probably get an implementation shortly.

but it seems that go team will not implement it very soon. 1 2

And I noticed that the dnsproxy is using quic-go for QUIC, and quic-go has a HTTP/3 implementation, so why not support it now? We can switch to the Go standard library once it has a implementation.

@ameshkov

Footnotes

  1. https://github.com/golang/go/issues/44886 ↩

  2. https://github.com/golang/go/issues/32204 ↩

@ameshkov ameshkov requested a review from ainar-g March 9, 2022 10:09
@hellodword
Copy link
Author

@ainar-g How do you think about this?

@ameshkov
Copy link
Member

Generally, it's not bad, we'll consider the PR, thank you!

@ainar-g
Copy link
Contributor

ainar-g commented May 24, 2022

We're currently very busy with a large number of tasks in our projects. While we're generally not against an HTTP/3 upstream and server support, I personally have some reservations regarding whether or not it should be a separate kinds of upstream. I think that net/http supports optional switch to HTTP/3 using ALPN, but I'm not sure.

@hellodword
Copy link
Author

https://security.googleblog.com/2022/07/dns-over-http3-in-android.html

Good news I guess.

@iJorgen
Copy link

iJorgen commented Aug 7, 2022

Any estimate when HTTP/3 upstream will be added? This month, this quarter, this year, next year? Fully understand your primary focus is on AdGuard Home right now, but would be so cool to use DNSproxy with all "next-gen" DNS-protocols.

PS. Just noticed DNSCrypt released HTTP/3 support a few days ago as a teaser... ;-)

@Potterli20 Potterli20 mentioned this pull request Aug 30, 2022
Closed
@ameshkov
Copy link
Member

Added here:
823fa92

After all, we decided not to make a separate Upstream for DOH3 and extend the existing one.

@ameshkov ameshkov closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ainar-g ainar-g Awaiting requested review from ainar-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hellodword @ameshkov @ainar-g @iJorgen